bito-code-review[bot] commented on code in PR #36344:
URL: https://github.com/apache/superset/pull/36344#discussion_r2574648995
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx:
##########
@@ -578,6 +593,20 @@ const config: ControlPanelConfig = {
colnames = updatedColnames;
coltypes = updatedColtypes;
}
+
+ const chartColumns =
+ explore?.controls?.chart_columns?.value || [];
+ if (Array.isArray(chartColumns)) {
+ chartColumns.forEach(
+ (col: { key: string; label: string; type: string }) => {
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Type annotation mismatch</b></div>
<div id="fix">
The type annotation in the forEach callback includes a 'type' property that
doesn't exist in ChartColumnConfig. This should be corrected to { key: string;
label: string } for proper TypeScript compliance.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
(col: { key: string; label: string }) => {
````
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/bce41c4/.cursor/rules/dev-standard.mdc#L35";>dev-standard.mdc:35</a>
</li>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/bce41c4/AGENTS.md#L57";>AGENTS.md:57</a>
</li>
</ul>
</details>
<small><i>Code Review Run #ebc0eb</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
