bito-code-review[bot] commented on code in PR #36348: URL: https://github.com/apache/superset/pull/36348#discussion_r2574849585
########## docs/docs/configuration/databases.mdx: ########## @@ -359,6 +360,20 @@ uses the default user without a password (and doesn't encrypt the connection): clickhousedb://localhost/default ``` +#### Cloudflare D1 + +To use Cloudflare D1 with superset, install the [superset-engine-d1](https://github.com/sqlalchemy-cf-d1/superset-engine-d1) library. + +``` +pip install superset-engine-d1 +``` + +The expected connection string is formatted as follows: + +``` +d1://{cloudflare_account_id}:{cloudflare_api_token}@{cloudflare_d1_database_id} +``` Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect Documentation</b></div> <div id="fix"> The new Cloudflare D1 section links to a non-existent GitHub repository and package, potentially confusing users. No evidence of official D1 support in Superset exists based on current documentation and searches. </div> </div> <small><i>Code Review Run #dbd316</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## docs/docs/configuration/databases.mdx: ########## @@ -54,6 +54,7 @@ are compatible with Superset. | [Ascend.io](/docs/configuration/databases#ascendio) | `pip install impyla` | `ascend://{username}:{password}@{hostname}:{port}/{database}?auth_mechanism=PLAIN;use_ssl=true` | | [Azure MS SQL](/docs/configuration/databases#sql-server) | `pip install pymssql` | `mssql+pymssql://UserName@presetSQL:[email protected]:1433/TestSchema` | | [ClickHouse](/docs/configuration/databases#clickhouse) | `pip install clickhouse-connect` | `clickhousedb://{username}:{password}@{hostname}:{port}/{database}` | +| [Cloudflare D1](/docs/configuration/databases#cloudflare-d1) | `pip install superset-engine-d1` | `d1://{cloudflare_account_id}:{cloudflare_api_token}@{cloudflare_d1_database_id}` | Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect Documentation</b></div> <div id="fix"> This addition references a non-existent package 'superset-engine-d1' and GitHub repository 'sqlalchemy-cf-d1/superset-engine-d1', which could mislead users attempting to configure Cloudflare D1 support. Official Superset documentation and searches confirm no such integration exists yet. </div> </div> <small><i>Code Review Run #dbd316</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
