YousufFFFF commented on code in PR #36306: URL: https://github.com/apache/superset/pull/36306#discussion_r2578332512
########## superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts: ########## @@ -433,69 +433,47 @@ export function getLegendProps( type: LegendType, orientation: LegendOrientation, show: boolean, - theme: SupersetTheme, + theme?: SupersetTheme, Review Comment: There’s no strong reason for making theme optional. That came from an earlier experiment and I forgot to change it back. I’ll keep theme required and continue using it for the legend/selector styling so existing behaviour isn’t changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
