aminghadersohi opened a new pull request, #36371:
URL: https://github.com/apache/superset/pull/36371
### SUMMARY
This PR updates the MCP service to use the dynamic `APP_NAME` configuration
instead of hardcoded "Superset" and "Apache Superset" references in
documentation, instructions, and prompts exposed to LLMs.
**Problem:** The MCP service had hardcoded "Superset" branding throughout
its LLM-facing documentation, tool docstrings, and prompts. This prevented
downstream projects from customizing the branding shown to LLMs and users when
they configure a different `APP_NAME`.
**Solution:** Replace hardcoded branding with dynamic values derived from
the Flask `APP_NAME` config:
- **`app.py`**: Updated default instructions to use generic resource URIs
(`instance/metadata` instead of `superset://instance/metadata`) and renamed
prompt reference from `superset_quickstart` to `quickstart`
- **`quickstart.py`**: Added `_get_app_name()` helper and updated prompt to
dynamically include the app name in welcome message and tool descriptions.
Renamed prompt from `superset_quickstart` to `quickstart`
- **`instance_metadata.py`**: Changed resource URI from
`superset://instance/metadata` to `instance://metadata` and updated docstring
- **`chart_configs.py`**: Changed resource URI from
`superset://chart/configs` to `chart://configs`
- **`get_instance_info.py`**: Removed "Superset" from module and tool
docstrings
- **`health_check.py`**: Updated docstring to show dynamic `{APP_NAME}`
example instead of hardcoded "Superset"
- **`simple_proxy.py`**: Changed proxy name from "Superset MCP Proxy" to
"MCP Proxy"
- **`mcp_config.py`**: Removed "Apache Superset" from module docstring
- **`middleware.py`**: Removed "Superset's" reference from logging
middleware docstring
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - This is a backend refactoring change affecting
documentation/instructions
### TESTING INSTRUCTIONS
1. Start the MCP service and verify the instructions returned use the
configured `APP_NAME`
2. Verify the quickstart prompt dynamically includes the app name
3. Verify health check response includes the configured app name in the
service field
4. Check that resource URIs work with the new naming scheme
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
