codeant-ai-for-open-source[bot] commented on PR #36360: URL: https://github.com/apache/superset/pull/36360#issuecomment-3604078161
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36360/files#diff-10627279de5c72b8c7b046ad6f7838aa4012d8798f891c2c11ce42578e420b63R70-R101'><strong>Possible Bug</strong></a><br>The `autorun` value taken from the URL/bootstrapped query is passed through verbatim into `newQueryEditor`. If this comes from querystring parameters it is likely a string (e.g. `'true'`, `'false'`, `'1'`), but the rest of the codebase treats `autorun` as a boolean. This can lead to unintended autorun behavior because any non-empty string is truthy.<br> - [ ] <a href='https://github.com/apache/superset/pull/36360/files#diff-10627279de5c72b8c7b046ad6f7838aa4012d8798f891c2c11ce42578e420b63R95-R103'><strong>Possible Bug</strong></a><br>`dbId` is derived with `Number(dbid)` when creating `newQueryEditor`. If `dbid` is missing or not a valid number, this will become `NaN`, which may break downstream logic that expects `dbId` to be either a valid numeric ID or `null`/`undefined`. Consider normalizing this consistently with other `addQueryEditor` call sites that use `parseInt` and fall back to `null`.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
