rebenitez1802 opened a new pull request, #36388: URL: https://github.com/apache/superset/pull/36388
## SUMMARY This PR fixes a critical dependency incompatibility that causes the "Cannot set properties of undefined (setting 'inTable')" error when rendering tables in Markdown components. ## PROBLEM - `remark-gfm` v4.0.1 requires `remark-parser` v11+ (unified v11) - `react-markdown` v8.0.7 uses `remark-parser` v10 (unified v10) - This version mismatch breaks table rendering in Markdown components across the entire application ## ROOT CAUSE 1. **March 2025**: Issue #32416 reported this problem with backticks in Markdown 2. **March 2025**: PR #32420 fixed it by pinning `remark-gfm` to v3 3. **July 2025**: Dependabot PR #32945 re-introduced the bug by auto-bumping to v4.0.1 4. **Current state**: The incompatibility affects all users trying to render tables in Markdown ## SOLUTION 1. Downgraded `remark-gfm` from ^4.0.1 to ^3.0.1 in `@superset-ui/core/package.json` 2. Added npm override in root `package.json` to **prevent Dependabot from auto-upgrading** this dependency 3. Regenerated `package-lock.json` to reflect the downgrade The npm override is critical - without it, Dependabot will continue to auto-bump `remark-gfm` to v4+, re-introducing the bug. ## ALTERNATIVE SOLUTION Upgrading to `react-markdown` v9+ would allow `remark-gfm` v4+, but that would be a larger change requiring: - Testing across all Markdown component usages - Potential breaking changes in react-markdown API - Regression testing for all markdown features ## TESTING ✅ Tables in Markdown components render correctly without errors ✅ Pre-commit hooks pass ✅ No breaking changes to existing Markdown functionality ## RELATED ISSUES - Fixes the regression introduced by #32945 (Dependabot bump to v4.0.1) - Re-implements the fix from #32420 with protection against future auto-upgrades - Related to #32416 (original issue report) ## CHECKLIST - [x] Has associated issue: - [x] Required feature flags: - [x] Changes UI - [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [x] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
