codeant-ai-for-open-source[bot] commented on PR #36402: URL: https://github.com/apache/superset/pull/36402#issuecomment-3605524530
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36402/files#diff-9e5762ab474e55120025ca4afd6643fa47dbf2ac56a09f38a0053cf4dc86abc1R350-R421'><strong>Possible Bug</strong></a><br>The test that spies on `dashboardStateActions.removeChartState` also calls `dashboardStateActions.removeChartState(chartId)` inside an assertion. This additional call can cause the spy assertion to pass even if `saveOrOverwrite` never invokes `removeChartState`, weakening the test and potentially hiding regressions in the cleanup logic.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
