codeant-ai-for-open-source[bot] commented on PR #36408: URL: https://github.com/apache/superset/pull/36408#issuecomment-3606781943
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36408/files#diff-2bd152cb850636957ebb8ed3337fc3214bc331e70dc1d5bce3edba151fafc7caR255-R279'><strong>Invalid JSON example</strong></a><br>The JSON code block under "UI Configuration" is missing commas (and therefore is not valid JSON). This will confuse users copying the sample into a JSON editor or the theme CRUD UI. Ensure commas between object properties and proper JSON booleans/values.<br> - [ ] <a href='https://github.com/apache/superset/pull/36408/files#diff-2bd152cb850636957ebb8ed3337fc3214bc331e70dc1d5bce3edba151fafc7caR323-R365'><strong>Broken Python example</strong></a><br>The "Corporate Branding" Python example omits a comma after the `fontFamily` entry and other commas may be missing between properties. These examples should be valid Python dict literals to avoid misleading users.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
