javacatknight commented on PR #36386: URL: https://github.com/apache/superset/pull/36386#issuecomment-3610293028
> I'm going to fix/do the pre-commit checks locally but regarding the license check, it's interesting that the rat check passed on the **.png** file in the directory, but not the .svg files. I ended up adding docs/static/img/logos/.*svg because for whatever reason, docs/static/img/logos/* only worked for the png file. Just commenting this for your interest, as someone in the future may want to add to the parent directory. Also maybe worth considering adding .*svg as a whole to the file, like .*json causing all json files to be excluded. Sorry about all the comments! Will definitely work with pre-commit more in the future 😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
