YousufFFFF commented on PR #36306: URL: https://github.com/apache/superset/pull/36306#issuecomment-3613887655
Thanks a lot for the thoughtful review, @rusackas really appreciate the clarity on these points! You're absolutely right about the `selected: undefined` field. I removed it during cleanup thinking it wasn’t required for the test, but I missed that the legend config still sets the `selected` prop. That removal is also the reason I switched to `expect.objectContaining`, since the stricter assertion no longer matched. I’ll revert that change so the test continues validating the full legend object, as before. Thanks for calling that out. I definitely don’t want to weaken the test coverage. Regarding the All/Inv buttons: yes, they are still present in the actual output (as expected), so removing them from the tests was unintentional on my part. I’ll restore those assertions so the test properly reflects the real behavior. I’ll push the corrective updates shortly and re-run the test suite to confirm everything aligns again. Thanks again for the thorough guidance and patience, really helping me understand the expectations and avoid regression🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
