codeant-ai-for-open-source[bot] commented on PR #36349: URL: https://github.com/apache/superset/pull/36349#issuecomment-3614149575
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36349/files#diff-5103dab5bddd059810efaaf1e0fb5f22ea751da590afcac99ebd247ab2ac1d2fR64-R79'><strong>Runtime Error</strong></a><br>The resolver uses an undefined variable `t` in `term.getShort(t)`. This will throw a ReferenceError at runtime when a glossary term is resolved, causing the Tooltip (and potentially other consumers) to crash. The glossary lookup code must be fixed or guarded at the call site.<br> - [ ] <a href='https://github.com/apache/superset/pull/36349/files#diff-4d4d9335e0b22097392f34af11feba72f62a0a7afe31087b4a8ae1dfb07e68f7R41-R46'><strong>decodeURIComponent can throw</strong></a><br>decodeURIComponent(window.location.hash.slice(1)) can throw if the hash contains malformed percent-encoding. This will break the effect and may cause an uncaught exception on page load.<br> - [ ] <a href='https://github.com/apache/superset/pull/36349/files#diff-0b1dc3b9840d544845571b6dc3da01c439b5cdfe4cdca495f72099fab9892727R32-R34'><strong>Behavioral Change</strong></a><br>The component returns `children` early when `title` is not a string. Previously the wrapper always rendered an Antd Tooltip and forwarded props. This change removes tooltips for non-string `title` values (e.g., React nodes) and is a breaking behavioral change that can remove intended tooltips across the app.<br> - [ ] <a href='https://github.com/apache/superset/pull/36349/files#diff-4ba6c4c6b48c5a8e8d62152f7c5d8dc9e4b2e808756539b9a91aaaea0152a356R23-R23'><strong>Unexpected default export</strong></a><br>The file exports an empty default object (`export default {}`) while also re-exporting a `glossary` named export from `glossaryUtils`. Consumers may import the default expecting the glossary implementation and get an empty object instead, causing runtime bugs or confusing API surface.<br> - [ ] <a href='https://github.com/apache/superset/pull/36349/files#diff-b5771855bc3458b6a0e2775c0df4926e0237287966a178352fb9e936dd77d254R39-R39'><strong>Build & type declarations</strong></a><br>Adding this re-export requires confirming that the build pipeline and type declarations include the glossary module (JS and .d.ts). Verify package exports/tsconfig and the published package include the module so consumers don't get runtime or typing errors.<br> - [ ] <a href='https://github.com/apache/superset/pull/36349/files#diff-b5771855bc3458b6a0e2775c0df4926e0237287966a178352fb9e936dd77d254R39-R39'><strong>Potential circular import</strong></a><br>Re-exporting a module from a central barrel can introduce circular dependencies if `./glossary` imports from other re-exported modules. Check for cycles to avoid runtime errors.<br> - [ ] <a href='https://github.com/apache/superset/pull/36349/files#diff-e8aa23ec31a264f87ba92ce3eef2133d44d0190ec08ac6d6eba4913d031294e9R90-R94'><strong>Missing doc file</strong></a><br>The sidebar references a doc id `glossary`. If there is no corresponding `docs/glossary.md` (or `docs/glossary/index.md`) this will cause the Docusaurus build to fail. Confirm the doc file exists and that the `id` matches the document frontmatter `id` (if present).<br> - [ ] <a href='https://github.com/apache/superset/pull/36349/files#diff-5103dab5bddd059810efaaf1e0fb5f22ea751da590afcac99ebd247ab2ac1d2fR24-R24'><strong>Hardcoded Base URL</strong></a><br>The base docs URL is hardcoded to 'http://localhost:3000/docs'. This will be incorrect in non-dev environments and forces http. It should be configurable (env/runtime) and default to the current origin or a build-time config so links are correct and use the appropriate scheme (https) in production.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
