SBIN2010 commented on code in PR #36332:
URL: https://github.com/apache/superset/pull/36332#discussion_r2592076970
##########
superset-frontend/src/explore/components/SaveModal.test.jsx:
##########
@@ -520,3 +520,90 @@ test('onTabChange correctly updates selectedTab via
forceUpdate', () => {
value: 'tab2',
label: 'Analytics Tab',
});
+});
+
+test('chart placement logic finds row with available space', () => {
+ const GRID_COLUMN_COUNT = 12; // From the actual implementation
+ const chartWidth = 4; // From the actual implementation
Review Comment:
👍I'll move the constants to superset-frontend/src/dashboard/constants.ts
And import them from there for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
