rusackas commented on PR #35525: URL: https://github.com/apache/superset/pull/35525#issuecomment-3639349618
Just had Claude take a fresh pass at this. Here's its assment: **Outstanding Code Review Issues** The automated reviewers flagged several items that appear unresolved: **Bito caught a real bug**: The import uses deprecated StaticMap which was removed in react-map-gl v8. Should be using Map component instead. This could cause runtime failures. **Korbit's unresolved items**: - Magic numbers (0.5, 100) in viewport offset calculations without constants - Over-permissive [key: string]: unknown index signatures reducing type safety - Uncached clustering computation (getClusters) running on every render (potential performance issue) **Risk Profile** This is a major version dependency upgrade on a visualization component. The combination of: - No testing instructions - No screenshots - Potential deprecated API usage - Performance concerns ...suggests this needs more verification before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
