codeant-ai-for-open-source[bot] commented on PR #36528: URL: https://github.com/apache/superset/pull/36528#issuecomment-3641586486
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36528/files#diff-ca979d47779775a35684e6bc7e75f60979654d37a86a5eb6b9376f663b68d601R248-R256'><strong>Global pointer-events change</strong></a><br>The new rule setting `pointer-events: none` on `.empty-droptarget` is broad and applies wherever `.dashboard-component-tabs-content > .empty-droptarget` exists. This may unintentionally alter click/interaction behavior outside of dashboard edit mode or in other contexts where the empty drop target is rendered. Verify the rule is intentionally global and validate behavior in both view and edit modes.<br> - [ ] <a href='https://github.com/apache/superset/pull/36528/files#diff-ca979d47779775a35684e6bc7e75f60979654d37a86a5eb6b9376f663b68d601R248-R256'><strong>Touch / mobile behavior</strong></a><br>`pointer-events` semantics differ across touch devices and layered elements. Ensure that disabling pointer events on the container and enabling them only on the child does not break drag interactions or tab taps on mobile / touch-based devices.<br> - [ ] <a href='https://github.com/apache/superset/pull/36528/files#diff-ca979d47779775a35684e6bc7e75f60979654d37a86a5eb6b9376f663b68d601R248-R256'><strong>Drop indicator hit area / z-index</strong></a><br>The fix relies on a small `.drop-indicator` child being the only element accepting pointer events. If `.drop-indicator` doesn't cover the full empty container or has a lower z-index, drag/drop may be hard to hit or fail. Confirm the `.drop-indicator` size/position and z-index ensure reliable drag targets.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
