codeant-ai-for-open-source[bot] commented on PR #36532: URL: https://github.com/apache/superset/pull/36532#issuecomment-3642472017
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36532/files#diff-fe59770000288da9bca75381ca9b5d44d076cba76c37a653881a12763ecbf96eR389-R415'><strong>Click target changed</strong></a><br>Icons were removed from inside the Link/Typography content and instead set as the MenuItem `icon` property. That can change the clickable area and keyboard focus behavior — clicking the icon might no longer activate the associated Link if the icon slot isn't inside the anchor. Verify that icons in the icon slot keep the same navigation/activation behaviour (mouse click, keyboard, screen readers) as before.<br> - [ ] <a href='https://github.com/apache/superset/pull/36532/files#diff-fe59770000288da9bca75381ca9b5d44d076cba76c37a653881a12763ecbf96eR379-R416'><strong>Visual/layout regression risk</strong></a><br>Moving icons from inline content into the Menu `icon` prop can affect layout rules (order, spacing) applied to `.ant-menu-item` and `.ant-menu-submenu-title`. Verify submenu headings, horizontal alignment, and responsive behavior to ensure spacing/ordering matches the intended design across breakpoints and RTL locales.<br> - [ ] <a href='https://github.com/apache/superset/pull/36532/files#diff-fe59770000288da9bca75381ca9b5d44d076cba76c37a653881a12763ecbf96eR392-R396'><strong>Missing test selectors</strong></a><br>Previously icons had `data-test` attributes (e.g. on the icon components). Since labels were changed to plain Link/Text nodes and icons moved, test selectors may need to be updated or new `data-test` attributes added to Link/Typography to keep automated tests stable.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
