aminghadersohi opened a new pull request, #36539: URL: https://github.com/apache/superset/pull/36539
### SUMMARY The `generate_chart` MCP tool was computing `form_data` but not returning it in the response. This field is required for external clients (e.g., chatbots) to render charts. **Changes:** - Add `form_data` and `form_data_key` fields to `GenerateChartResponse` schema - Generate `form_data_key` for saved charts (previously only generated for preview mode) - Use `serialize_chart_object` to populate all chart fields properly (fixes many null fields) - Return `form_data` and `form_data_key` in `generate_explore_link` response ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before:** `form_data` and `form_data_key` were missing or null in generate_chart response **After:** Both fields are populated with the chart configuration data ### TESTING INSTRUCTIONS 1. Call the `generate_chart` MCP tool with a valid dataset and chart config 2. Verify the response contains `form_data` with the chart configuration 3. Verify the response contains `form_data_key` with a cache key 4. Verify `chart.form_data` is also populated (previously always null) ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
