aminghadersohi commented on PR #36553: URL: https://github.com/apache/superset/pull/36553#issuecomment-3645270883
Addressed review comments in commit 91897a6: 1. **core_mcp_injection.py:96** - Now using `getattr(tool, 'task', task)` to get the effective task state from the registered tool object, ensuring accurate logging even if compatibility fallback changes the task registration. 2. **generate_dashboard.py:250-251** - Reordered error handling to log locally first, then attempt context error reporting wrapped in try/except to avoid masking the original exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
