imad-hl commented on PR #35859: URL: https://github.com/apache/superset/pull/35859#issuecomment-3647021245
> Eek... some conflicts have arisen due to another recently merged PR. Could you take a look at rebasing? Hope I didn't cause too much trouble. > > Otherwise, I think the shift-click thing is a little... unusual... but I don't mind it all that much. It's hard to discover, so a docs entry couldn't hurt, OR adapting this to other cross-filter-emitting charts like Pie Charts or Bar Charts. That'd be cool, unless there's a better, more visibly obvious pattern here (@kasiazjc might have ideas). Hi! I think I got the conflicts sorted out. The recently merged PR added a nice tooltip feature on hover, which is now integrated. About the shift-click multiselect : I agree it's not very discoverable. I've removed it and simplified the behavior to match what other cross-filter charts do (Pie, Bar, etc.). I do think shift-multiselect could be a good addition if implemented consistently across all cross-filter charts, but for this PR I'll stick with removing it and keeping things aligned with the existing patterns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
