mistercrunch opened a new pull request, #36597:
URL: https://github.com/apache/superset/pull/36597
### SUMMARY
When running webpack-dev-server with `WEBPACK_DEVSERVER_HOST=0.0.0.0` in
Docker environments, external IP access was blocked because `allowedHosts` was
hardcoded to only allow localhost variants.
This adds `devserverHost` to the `allowedHosts` array so that accessing the
dev server via external IPs works when explicitly configured to bind to all
interfaces. The `Set` ensures deduplication if `devserverHost` happens to match
an existing entry.
**Before:** Setting `WEBPACK_DEVSERVER_HOST=0.0.0.0` binds the server to all
interfaces, but requests from external IPs are rejected due to Host header
validation.
**After:** The configured `devserverHost` is automatically included in
`allowedHosts`, allowing access from the bound interface.
### TESTING INSTRUCTIONS
1. Start the dev environment with external binding:
```bash
WEBPACK_DEVSERVER_HOST=0.0.0.0 NODE_PORT=9001 docker compose -f
docker-compose-light.yml up -d
```
2. Access from an external IP (e.g., `http://<your-machine-ip>:9001/`)
3. Verify the page loads instead of being blocked
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
