mistercrunch commented on issue #6946: [sqla] Handling subquery error URL: https://github.com/apache/incubator-superset/pull/6946#issuecomment-508353730 Maybe `SqlaTable.query` needs to be refactored/broken down into 2 parts, one that raises if it fails and returns a dataframe only (say `get_df_from_query_obj`), and the current `query` method would wrap that `get_df_from_query_obj` in a `try:` block and return a `QueryResult` object. The call here would aim at `get_df_from_query_obj` instead of `self.query`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
