pizofreude commented on code in PR #36422: URL: https://github.com/apache/superset/pull/36422#discussion_r2617204504
########## superset/commands/database/validate_sql.py: ########## @@ -32,6 +32,7 @@ ) from superset.daos.database import DatabaseDAO from superset.errors import ErrorLevel, SupersetError, SupersetErrorType +from superset.jinja_context import get_template_processor Review Comment: Rendering templates before validation makes sense to avoid spurious syntax errors. Two quick questions: 1. Is template processing gated by the ENABLE_TEMPLATE_PROCESSING feature flag elsewhere, or should we guard this call here if the flag is off? 1. If template processing raises an error (e.g., because of an undefined filter or runtime issue), how is that surfaced to the client? Could you add a short comment or a test case showing expected behavior on template-processing errors? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
