codeant-ai-for-open-source[bot] commented on PR #36639: URL: https://github.com/apache/superset/pull/36639#issuecomment-3655351110
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36639/files#diff-a612babd68b1abfd9dd4ebeff1bec35c7512602e35846c4058aacbac65c6c7beR488-R491'><strong>Async error shape</strong></a><br>When GlobalAsyncQueries is enabled the raw `response` is forwarded into `chartUpdateFailed([response], key)`. Ensure the consumers/reducers expect this raw shape and that it contains the needed fields (message/error/is_cached). Consider normalizing the error shape before dispatch to avoid downstream surprises.<br> - [ ] <a href='https://github.com/apache/superset/pull/36639/files#diff-a612babd68b1abfd9dd4ebeff1bec35c7512602e35846c4058aacbac65c6c7beR479-R486'><strong>Abort detection</strong></a><br>The new abort handling checks `response?.name === 'AbortError'` and `response?.message === 'Request aborted'`. Different runtimes and the Superset client may surface aborts using `statusText === 'abort'`, a DOMException, or other shapes. Verify all abort cases are caught and not treated as real errors.<br> - [ ] <a href='https://github.com/apache/superset/pull/36639/files#diff-a612babd68b1abfd9dd4ebeff1bec35c7512602e35846c4058aacbac65c6c7beR479-R515'><strong>Error logging behavior change</strong></a><br>Previously aborts appended an 'abort' error log. The new code ignores aborts completely (no log). Confirm this is intentional (aborts shouldn't be logged), and if some telemetry is still desired, add a non-error log path instead of dropping it entirely.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
