codeant-ai-for-open-source[bot] commented on PR #36642: URL: https://github.com/apache/superset/pull/36642#issuecomment-3657548652
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36642/files#diff-7e528693a8f9063f0b2889785aba5e3363aa2e27d30274f624dca1639724fe9fR432-R446'><strong>Inconsistent waiting</strong></a><br>The PR fixes several race conditions by switching to async `findByText` for nested menu items, but there are still places using synchronous queries (e.g. `getByLabelText` / `getByText`) elsewhere. Mixed sync/async queries increase the chance of flakiness — ensure all interactions that depend on async rendering consistently await the element (menu trigger, top-level menu, and submenu entries).<br> - [ ] <a href='https://github.com/apache/superset/pull/36642/files#diff-7e528693a8f9063f0b2889785aba5e3363aa2e27d30274f624dca1639724fe9fR596-R624'><strong>Double restore risk</strong></a><br>Several tests call `spyExportChart.restore()` (and similar restores) inside the test body while an afterEach hook also restores the same sinon spies. Double-restoring a sinon spy/stub can throw or lead to unexpected behavior; centralize restore logic in the shared teardown or remove the extra restores.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
