rusackas commented on code in PR #36127:
URL: https://github.com/apache/superset/pull/36127#discussion_r2622092915
##########
superset-frontend/src/features/alerts/types.ts:
##########
@@ -173,6 +174,7 @@ export enum RecipientIconName {
Email = 'Email',
Slack = 'Slack',
SlackV2 = 'SlackV2',
+ Webhook = 'Webhook',
Review Comment:
Valid concern, but pre-existing pattern
Looking at the code:
typescriptexport enum NotificationMethodOption {
Email = 'Email',
Slack = 'Slack',
SlackV2 = 'SlackV2',
Webhook = 'Webhook'
}
// ...
export enum RecipientIconName {
Email = 'Email',
Slack = 'Slack',
SlackV2 = 'SlackV2',
Webhook = 'Webhook',
}
The duplication concern is real, but all existing values (Email, Slack,
SlackV2) have the same duplication. This PR just follows the established
pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
