michael-s-molina commented on code in PR #36644: URL: https://github.com/apache/superset/pull/36644#discussion_r2622918575
########## superset-frontend/src/SqlLab/components/SqlEditorTopBar/index.tsx: ########## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { EmptyState, Flex, Space } from '@superset-ui/core/components'; +import { DatabaseSelector } from 'src/components'; +import ExtensionsManager from 'src/extensions/ExtensionsManager'; + +import useDatabaseSelector from './useDatabaseSelector'; +import RunQueryActionButton from '../RunQueryActionButton'; +import QueryLimitSelect from '../QueryLimitSelect'; + +export interface SqlEditorTopBarProps { + queryEditorId: string; +} + +const SqlEditorTopBar = ({ + queryEditorId, + secondaryActions, +}: SqlEditorTopBarProps) => { + const dbSelectorProps = useDatabaseSelector(queryEditorId); + const contributions = Review Comment: Instead of modifying each view individually to add the primary/secondary actions, can't we create a component like `ActionPanel` that handles primary/secondary actions and accepts the views as its children? ########## superset-frontend/src/extensions/ExtensionsManager.ts: ########## @@ -57,15 +57,19 @@ class ExtensionsManager { * @throws Error if initialization fails. */ public async initializeExtensions(): Promise<void> { - const response = await SupersetClient.get({ - endpoint: '/api/v1/extensions/', - }); - const extensions: core.Extension[] = response.json.result; - await Promise.all( - extensions.map(async extension => { - await this.initializeExtension(extension); - }), - ); + try { Review Comment: Why do you need to add a try/catch here? Isn't this handled by the caller? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
