LuisSanchez commented on code in PR #36486:
URL: https://github.com/apache/superset/pull/36486#discussion_r2623348829
##########
superset-frontend/packages/superset-ui-core/src/components/TimezoneSelector/index.tsx:
##########
@@ -17,19 +17,37 @@
* under the License.
*/
-import { useEffect, useMemo } from 'react';
+import { useCallback, useMemo, useState } from 'react';
import { t } from '@superset-ui/core';
import { Select } from '@superset-ui/core/components';
import { isDST, extendedDayjs } from '../../utils/dates';
+export type TimezoneSelectorProps = {
+ onTimezoneChange: (value: string) => void;
+ timezone?: string | null;
+ minWidth?: string;
+ placeholder?: string;
+};
+
+type TimezoneOption = {
+ label: string;
+ value: string;
+ offsets: string;
+ timezoneName: string;
+};
+
const DEFAULT_TIMEZONE = {
name: 'GMT Standard Time',
value: 'Africa/Abidjan', // timezones are deduped by the first alphabetical
value
};
const MIN_SELECT_WIDTH = '400px';
+const DROPDOWN_MIN_HEIGHT = 265;
Review Comment:
Yeah, I know what you mean, gonna double check!
For more context, this is what is happening without the min_height hack:
https://github.com/user-attachments/assets/3368fab5-4de0-4c77-91f1-fdd62286e10c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
