Vitor-Avila commented on code in PR #36679:
URL: https://github.com/apache/superset/pull/36679#discussion_r2624160634
##########
superset/datasets/schemas.py:
##########
@@ -257,6 +257,7 @@ def fix_extra(self, data: dict[str, Any], **kwargs: Any) ->
dict[str, Any]:
expression = fields.String(allow_none=True)
description = fields.String(allow_none=True)
python_date_format = fields.String(allow_none=True)
+ datetime_format = fields.String(allow_none=True)
Review Comment:
This is technically correct, but it's the current pattern for import
operations. We should have a follow up dedicated primarily on fixing this
across all import schemas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
