thoralf-gutierrez commented on issue #7717: [WIP] Refactor testconn to use get_sqla_engine URL: https://github.com/apache/incubator-superset/pull/7717#issuecomment-508960657 Thanks for the early comments @john-bodley -- I fixed how I was creating the database (needed to use `set_sqlalchemy_uri`) and now the test passes. I think I've also addressed your comments. Can you take a second look?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
