codeant-ai-for-open-source[bot] commented on PR #36314: URL: https://github.com/apache/superset/pull/36314#issuecomment-3667826810
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36314/files#diff-e046b298e26be68e617e79f1841e95487f453c528eaa36b4cb9d28c0f90fd71bR22-R22'><strong>Possible Build Failure</strong></a><br>The file re-exports `RENDER_TAB` and `RENDER_TAB_CONTENT` from `./Tab`. If `./Tab` does not export these exact named symbols (or they were renamed during the migration to TypeScript), this will cause a build-time import error. Confirm the names are exported from `Tab.tsx` and that they are named (not default) exports.<br> - [ ] <a href='https://github.com/apache/superset/pull/36314/files#diff-b4bbbab0a6251b68a97294c6180304e149b59264243249002c4a303a70bf00e7R52-R53'><strong>PropTypes completeness</strong></a><br>The PR adds `onDrop` and `onHover` to `propTypes`. Verify these match how child components call them (parameters and required-ness). If children expect these callbacks to always exist, runtime errors will occur when they are undefined.<br> - [ ] <a href='https://github.com/apache/superset/pull/36314/files#diff-b4bbbab0a6251b68a97294c6180304e149b59264243249002c4a303a70bf00e7R52-R59'><strong>Missing default values</strong></a><br>Newly added function props can be undefined at runtime. Confirm whether `DashboardComponent` or consuming children guard calls to these callbacks, or add safe defaults (no-op functions) to avoid TypeErrors when invoked.<br> - [ ] <a href='https://github.com/apache/superset/pull/36314/files#diff-540a12a8cd7c8bed3b58b6694e690b3c70d2c401b6df314f74c4bc52495cbda7R132-R133'><strong>Missing reducer/initialState updates</strong></a><br>The PR adds `lastRefreshTime` and `tabActivationTimes` to `DashboardState` types. Verify that the dashboard reducer(s) and initial state are updated to actually set and maintain these properties; otherwise the new types will be silent and runtime code may never populate them, causing unexpected undefined behavior where callers expect values.<br> - [ ] <a href='https://github.com/apache/superset/pull/36314/files#diff-d700aa2ab6de8b29cb2cb7342800c1484a79e7234719492a7947812071d12395R43-R74'><strong>Weak typing</strong></a><br>Several props in the new `TabProps` interface use overly-broad types (`Function`, `(...args: unknown[]) => unknown`, `unknown[]`) or leave important callback parameters untyped. This reduces type-safety and can hide runtime issues — e.g., `updateComponents`, `onDropOnTab`, and the various drop handlers should have explicit, narrow signatures matching the shapes used by the dnd system and dashboard layout.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
