betodealmeida commented on PR #36742: URL: https://github.com/apache/superset/pull/36742#issuecomment-3671230546
Thanks for the review! Addressing the concerns raised: ### Re: `not_in` vs `notin_` Both methods exist in SQLAlchemy - `not_in` is an alias for `notin_`. The existing `BaseFilterRelatedUsers` in `superset/views/filters.py:85` uses the same `not_in` method: ```python return query.filter(and_(user_model.username.not_in(exclude_users))) ``` ### Re: Config access risk `EXCLUDE_USERS_FROM_LISTS` is always defined in `superset/config.py:1718`: ```python EXCLUDE_USERS_FROM_LISTS: list[str] | None = None ``` This matches the existing pattern used in `BaseFilterRelatedUsers` which also accesses `app.config["EXCLUDE_USERS_FROM_LISTS"]` directly without `.get()`. ### Re: Test patterns The test patterns follow similar approaches used elsewhere in the codebase (e.g., `tests/unit_tests/databases/filters_test.py`). The tests pass and validate the expected behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
