rusackas commented on PR #36741:
URL: https://github.com/apache/superset/pull/36741#issuecomment-3671438109

   Thanks @rad-pat!
   
   Two little things for us to contend with:
   
   1) It looks like the logo is a big (page size) SVG with the logo floating in 
the middle, which means the logo would be teensy when it's squeezed down to fit 
the card. Do you have one that's more reasonably cropped?
   
   2) I see the `pre-commit` is barking about the SVG file missing a newline at 
the end of file. You're welcome to fix that too, but I think I'll remove that 
check for this images directory so others don't get stuck on this too. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to