bito-code-review[bot] commented on code in PR #36761:
URL: https://github.com/apache/superset/pull/36761#discussion_r2634300964
##########
docs/docusaurus.config.ts:
##########
@@ -343,6 +351,10 @@ const config: Config = {
return
`https://github.com/apache/superset/edit/master/docs/${versionDocsDirPath}/${docPath}`;
},
remarkPlugins: [remarkImportPartial, remarkLocalizeBadges],
+ admonitions: {
+ keywords: ['note', 'tip', 'info', 'warning', 'danger',
'resources'],
+ extendDefaults: true,
+ },
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Admonition Type for 'warning'</b></div>
<div id="fix">
The admonitions config adds 'warning' to keywords, but no corresponding
AdmonitionType component exists in the theme, which may cause :::warning blocks
(used in 10 docs files) to render without expected styling or icons, per
Docusaurus docs requiring theme mapping for custom keywords.
</div>
</div>
<small><i>Code Review Run #59406c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/docs/quickstart.mdx:
##########
@@ -80,3 +80,10 @@ From this point on, you can head on to:
- [Installing on Kubernetes](/docs/installation/kubernetes/)
Or just explore our [Documentation](https://superset.apache.org/docs/intro)!
+
+:::resources
+- [Video: Superset in 2 Minutes](https://www.youtube.com/watch?v=AqousXQ7YHw)
+- [Video: Superset 101](https://www.youtube.com/watch?v=mAIH3hUoxEE)
+- [Blog: Getting Started with Apache
Superset](https://preset.io/blog/apache-superset-quick-start/)
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken external link</b></div>
<div id="fix">
The link to the Preset blog post returns a 404 error, which could frustrate
users seeking quick-start guidance. Consider updating to a current Preset
resource on Superset getting started, or removing this entry.
</div>
</div>
<small><i>Code Review Run #59406c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/docusaurus.config.ts:
##########
@@ -70,6 +74,10 @@ if (!versionsConfig.developer_portal.disabled) {
editUrl:
'https://github.com/apache/superset/edit/master/docs/developer_portal',
remarkPlugins: [remarkImportPartial, remarkLocalizeBadges],
+ admonitions: {
+ keywords: ['note', 'tip', 'info', 'warning', 'danger', 'resources'],
+ extendDefaults: true,
+ },
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Admonition Type for 'warning'</b></div>
<div id="fix">
The admonitions config adds 'warning' to keywords, but no corresponding
AdmonitionType component exists in the theme, which may cause :::warning blocks
(used in 10 docs files) to render without expected styling or icons, per
Docusaurus docs requiring theme mapping for custom keywords.
</div>
</div>
<small><i>Code Review Run #59406c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/docusaurus.config.ts:
##########
@@ -46,6 +46,10 @@ if (!versionsConfig.components.disabled) {
editUrl:
'https://github.com/apache/superset/edit/master/docs/components',
remarkPlugins: [remarkImportPartial, remarkLocalizeBadges],
+ admonitions: {
+ keywords: ['note', 'tip', 'info', 'warning', 'danger', 'resources'],
+ extendDefaults: true,
+ },
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Admonition Type for 'warning'</b></div>
<div id="fix">
The admonitions config adds 'warning' to keywords, but no corresponding
AdmonitionType component exists in the theme, which may cause :::warning blocks
(used in 10 docs files) to render without expected styling or icons, per
Docusaurus docs requiring theme mapping for custom keywords.
</div>
</div>
<small><i>Code Review Run #59406c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
