michael-s-molina commented on code in PR #36768:
URL: https://github.com/apache/superset/pull/36768#discussion_r2635217314
##########
superset-extensions-cli/src/superset_extensions_cli/cli.py:
##########
@@ -479,6 +479,11 @@ def init(
(target_dir / "extension.json").write_text(extension_json)
click.secho("✅ Created extension.json", fg="green")
+ # Create .gitignore
+ gitignore = env.get_template(".gitignore.j2").render(ctx)
+ (target_dir / ".gitignore").write_text(gitignore)
Review Comment:
The explicit encoding is a defensive practice for Windows compatibility, but
it's not strictly necessary for this codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
