codeant-ai-for-open-source[bot] commented on PR #36793: URL: https://github.com/apache/superset/pull/36793#issuecomment-3681729285
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36793/files#diff-ecf53b9bdd6afc93272e2b576cc8fd95671126e3441ef8b077e208b2dc372da0R214-R218'><strong>Units mismatch</strong></a><br>The change replaces a previous `getLineWidth` accessor with a `lineWidthMinPixels` constant that depends on `fd.stroked`. If `fd.line_width_unit` can be a unit other than pixels (e.g., 'meters'), `lineWidthMinPixels` may not be the correct property to control line width in those units — this can cause unexpected behavior for non-pixel units.<br> - [ ] <a href='https://github.com/apache/superset/pull/36793/files#diff-ecf53b9bdd6afc93272e2b576cc8fd95671126e3441ef8b077e208b2dc372da0R214-R221'><strong>deck.gl compatibility</strong></a><br>Ensure the chosen properties (`lineWidthMinPixels`, `lineWidthUnits`) match the deck.gl version in use. Some versions expect `getLineWidth`, `lineWidthScale`, or different combinations to correctly render polygon outlines.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
