rusackas commented on PR #36760: URL: https://github.com/apache/superset/pull/36760#issuecomment-3684005647
The `any` types with `eslint-disable` comments are intentional for this migration PR. These utility functions handle dynamic values from various sources (URL params, Redux state, user input) that can have multiple shapes: - `getOptionsForSavedMetrics`: `currentMetricValues` can be an array or single value - `isDictionaryForAdhocMetric`: Type guard for unknown value shapes - `coerceAdhocMetrics`: Converts various value types to AdhocMetric instances Adding proper union types for these would require significant refactoring to trace all call sites and their expected types, which is beyond the scope of this JS-to-TS migration. The eslint-disable comments document this technical debt for future improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
