bito-code-review[bot] commented on code in PR #36819:
URL: https://github.com/apache/superset/pull/36819#discussion_r2644687588
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -385,7 +385,7 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
const nums = data
?.map(row => row?.[key])
.filter(value => typeof value === 'number') as number[];
- if (data && nums.length === data.length) {
+ if (nums.length > 0) {
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Runtime Error Risk</b></div>
<div id="fix">
The condition change from checking 'data && nums.length === data.length' to
'nums.length > 0' can cause a runtime TypeError if data is undefined, since
nums would be undefined and accessing its length throws an error. The optional
chaining on data suggests it can be undefined in some cases.
</div>
</div>
<small><i>Code Review Run #0fa8d5</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
