codeant-ai-for-open-source[bot] commented on PR #36847: URL: https://github.com/apache/superset/pull/36847#issuecomment-3694101357
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36847/files#diff-9397002a1289beaeabdbe74618700b41ddc5506c8a710d2a9c4f119eedc76c20R168-R178'><strong>Numeric parsing edge case</strong></a><br>The metric value parsing uses Number(v) for non-number inputs; this converts empty strings to 0 which can incorrectly inflate metricMin/Max and cause useSequential to be true/false incorrectly. Ensure null/empty strings and non-numeric values are excluded rather than coerced to 0.<br> - [ ] <a href='https://github.com/apache/superset/pull/36847/files#diff-9397002a1289beaeabdbe74618700b41ddc5506c8a710d2a9c4f119eedc76c20R218-R231'><strong>Label de-emphasis</strong></a><br>De-emphasis applies an opacity to the node's itemStyle but the label is left unchanged (labelProps has no opacity). Labels may remain fully opaque and visually prominent even when the node rectangle is muted. Verify labels inherit or are explicitly muted so de-emphasis visually reduces both fill and text.<br> - [ ] <a href='https://github.com/apache/superset/pull/36847/files#diff-a95df502a50668669cd1a778ce3f25bc83b3481062af86e1c200147f3662acadR24-R27'><strong>Accessibility / contrast</strong></a><br>Removing the label box/background can reduce text contrast on varied node colors. Ensure contrast/accessibility is preserved (e.g., test on dark/light node colors) or ensure consumers apply appropriate text shadows/contrast-aware styles.<br> - [ ] <a href='https://github.com/apache/superset/pull/36847/files#diff-9397002a1289beaeabdbe74618700b41ddc5506c8a710d2a9c4f119eedc76c20R319-R340'><strong>visualMap configuration</strong></a><br>visualMap is assigned dynamically but lacks an explicit 'type' (continuous) and may rely on defaults. Also the fallback colors are built from categorical colorFn('min'/'max') which could mismatch true sequential palettes. Verify visualMap.type and color selection logic to ensure correct continuous mapping and consistent color intent.<br> - [ ] <a href='https://github.com/apache/superset/pull/36847/files#diff-a95df502a50668669cd1a778ce3f25bc83b3481062af86e1c200147f3662acadR24-R27'><strong>Visual regression risk</strong></a><br>Changing the default BORDER_WIDTH and GAP_WIDTH from 2 to 0 will remove the thin gap and label box, but may cause label overlap or reduced readability on certain datasets/backgrounds. Validate across multiple datasets, sizes, DPI/zoom levels and with long labels to ensure no overlap or truncation/regression is introduced.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
