robjuffermans commented on PR #36849: URL: https://github.com/apache/superset/pull/36849#issuecomment-3694812545
Thanks for the feedback! You're correct that the project is modernizing to TypeScript. However, converting the entire TableRenderers.jsx file (~950 lines) to TypeScript is a significant refactoring effort that's beyond the scope of this feature PR. I'd prefer to keep this PR focused on the new functionality. The TypeScript conversion of the react-pivottable folder would be better suited as a separate modernization PR. Would you be okay with merging this as-is and addressing the TS conversion in a follow-up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
