msyavuz opened a new pull request, #36854:
URL: https://github.com/apache/superset/pull/36854

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   When creating a database connection with validation errors (e.g., duplicate 
database name), users had to manually dismiss error messages before being able 
to successfully connect, even
   after fixing the underlying issue.
   
   Added handleClearValidationErrors() calls to all form field onChange 
handlers in DatabaseModal/index.tsx. Now when users modify any form field after 
encountering validation errors, the
   errors are automatically cleared, allowing immediate reconnection once the 
issue is resolved.
   
   Reproduction steps:
   1. Create a Google Sheets database and save it
   2. Create a new Google Sheets database with the same name
   3. Get validation error (expected)
   4. Change the display name to fix the issue
   5. Try to connect again → Connection appears to fail because errors aren't 
cleared
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   Run testing suite or follow repro steps
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to