Khrol commented on code in PR #36857:
URL: https://github.com/apache/superset/pull/36857#discussion_r2652435255
##########
superset/views/base.py:
##########
@@ -479,7 +479,7 @@ def cached_common_bootstrap_data( # pylint:
disable=unused-argument
auth_type = app.config["AUTH_TYPE"]
auth_user_registration = app.config["AUTH_USER_REGISTRATION"]
frontend_config["AUTH_USER_REGISTRATION"] = auth_user_registration
- should_show_recaptcha = auth_user_registration and (auth_type !=
AUTH_OAUTH)
+ should_show_recaptcha = auth_user_registration and (auth_type !=
AUTH_OAUTH) and (auth_type != AUTH_LDAP)
Review Comment:
Well, this is the exact problem I try to fix. I'm not sure if it's fine to
define `should_show_recaptcha` logic based on `RECAPTCHA_PUBLIC_KEY` presence.
I'll leave it for reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
