gnetsman commented on issue #34076:
URL: https://github.com/apache/superset/issues/34076#issuecomment-3699200917
> I think the bot is right here. Just opened up a PR to close this out.
@rusackas It looks like the PR is not fixing the issue. The call linked
above is calling `page.goto(headless_url("/login/"))` without `wait_until=`
unlike
https://github.com/apache/superset/blob/42db43c68683b0fce73d87cda885b379c2a41d4d/superset/utils/webdriver.py#L164
I see the call failing with `load` being still used in my setup (6.0.0)
`Call log:
- navigating to "http://superset:8088/login/", waiting until "load"
Traceback (most recent call last):
File "/app/superset/commands/report/execute.py", line 375, in
_get_screenshots
if imge := screenshot.get_screenshot(user=user):
File "/app/superset/utils/screenshots.py", line 190, in get_screenshot
self.screenshot = driver.get_screenshot(self.url, self.element, user)
File "/app/superset/utils/webdriver.py", line 178, in get_screenshot
self.auth(user, context)
File "/app/superset/utils/webdriver.py", line 103, in auth
return
machine_auth_provider_factory.instance.authenticate_browser_context(
File "/app/superset/utils/machine_auth.py", line 93, in
authenticate_browser_context
page.goto(headless_url("/login/"))
File
"/app/.venv/lib/python3.10/site-packages/playwright/sync_api/_generated.py",
line 9050, in goto
self._sync(
File
"/app/.venv/lib/python3.10/site-packages/playwright/_impl/_sync_base.py", line
115, in _sync
return task.result()
File "/app/.venv/lib/python3.10/site-packages/playwright/_impl/_page.py",
line 552, in goto
return await self._main_frame.goto(**locals_to_params(locals()))
File "/app/.venv/lib/python3.10/site-packages/playwright/_impl/_frame.py",
line 153, in goto
await self._channel.send(
File
"/app/.venv/lib/python3.10/site-packages/playwright/_impl/_connection.py", line
69, in send
return await self._connection.wrap_api_call(
File
"/app/.venv/lib/python3.10/site-packages/playwright/_impl/_connection.py", line
559, in wrap_api_call
raise rewrite_error(error, f"{parsed_st['apiName']}: {error}") from None`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]