justinpark commented on code in PR #36644:
URL: https://github.com/apache/superset/pull/36644#discussion_r2658190432
##########
superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx:
##########
@@ -62,32 +64,30 @@ const buildTextAndIcon = (
};
const onClick = (
- shouldShowStopButton: boolean,
- allowAsync: boolean,
+ isStopAction: boolean,
runQuery: (c?: boolean) => void = () => undefined,
stopQuery = () => {},
logAction: (name: string, payload: Record<string, any>) => void,
): void => {
- const eventName = shouldShowStopButton
+ const eventName = isStopAction
? LOG_ACTIONS_SQLLAB_STOP_QUERY
: LOG_ACTIONS_SQLLAB_RUN_QUERY;
logAction(eventName, { shortcut: false });
- if (shouldShowStopButton) return stopQuery();
- if (allowAsync) {
- return runQuery(true);
- }
- return runQuery(false);
+ if (isStopAction) return stopQuery();
+ runQuery();
Review Comment:
Removed `allowAsync` since runQuery does *not* reference the value anymore.
https://github.com/apache/superset/blob/e5489bd30f590040631a8a1604091e3ca785f459/superset-frontend/src/SqlLab/components/SqlEditor/index.tsx#L313-L317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
