SBIN2010 commented on PR #35459: URL: https://github.com/apache/superset/pull/35459#issuecomment-3711682415
> Agreed with Michael on the issue of control panel complexity as we edge closer and closer to supporting all the ECharts features. > > I also wonder if this thing starts to collide with the intent of the Gauge chart (which is hard to use, in my opinion). Maybe some day we can consolidate the two, if we design it well. > > What @michael-s-molina is referring to, @SBIN2010, is that I have this "rainy day" plan that you'd be more than welcome to adopt on a PR. I was hoping to make a reusable Code Editor control panel input (promoting the one used by the Handlebars Chart) in one PR, and then give it a JSON editor mode. Once it has that, one could simply type up a JSON object of ECharts options... then you could add spacing between pie wedges, round the corners of wedges, or do whatever you want, really. Hi @michael-s-molina @rusackas! @rusackas , thank you very much for the clarification, now everything is clear to me. However, I don't entirely agree with you. You can put settings in JSON that wouldn't have dependencies on other settings. Take this PR as an example: if we are making a setting to display the donut percentage, we need to consider that the total display will no longer be centered, and also if the legend display changes, that must be taken into account as well. If we consider other settings, like those @rusackas mentioned, which don't have dependent settings, it would be more reasonable to wrap them in JSON. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
