codeant-ai-for-open-source[bot] commented on PR #36909: URL: https://github.com/apache/superset/pull/36909#issuecomment-3712911910
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36909/files#diff-94d3bd02afcbd1983033ed9c33e9efb466cb9a64e3b1f3954e6e0d627f70d0efR128-R193'><strong>Tests / Backwards compatibility</strong></a><br>There are no tests included that assert the new column is persisted and serialized. Add unit/integration tests ensuring the column is present, nullable behavior is correct, and the frontend/API surfaces the expected values. Also validate any core/shared models or type definitions that might need updates.<br> - [ ] <a href='https://github.com/apache/superset/pull/36909/files#diff-94d3bd02afcbd1983033ed9c33e9efb466cb9a64e3b1f3954e6e0d627f70d0efR140-R142'><strong>DB Migration</strong></a><br>A new ORM column `progress_text` was added to the `query` model. This requires an Alembic migration to add the column to the `query` table (and a downgrade that drops it). Ensure the migration is created, reviewed, and run on deployments to avoid runtime schema mismatches.<br> - [ ] <a href='https://github.com/apache/superset/pull/36909/files#diff-94d3bd02afcbd1983033ed9c33e9efb466cb9a64e3b1f3954e6e0d627f70d0efR172-R186'><strong>Serialization compatibility</strong></a><br>The new `progressText` field is added to `Query.to_dict()`. Verify API contracts and frontend consumers handle `null`/empty values correctly. Consider normalizing the value (e.g., empty string) or documenting the new field in API schemas so clients don't break on unexpected nulls.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
