gabotorresruiz opened a new pull request, #36932: URL: https://github.com/apache/superset/pull/36932
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The Ace Editor text selection highlight in SQL Lab uses `colorPrimaryBgHover`, which is too similar to the active line color `(colorPrimaryBg)`. This makes text selection nearly invisible, especially when selecting text on the current line. Changes: - Added a new optional theme token `colorEditorSelection` to `SupersetSpecificTokens` interface - Updated `AsyncAceEditor` to use `colorEditorSelection` with fallback to `colorPrimaryBgHover` for backwards compatibility This allows theme configurations to specify a distinct selection color while maintaining backwards compatibility with existing themes. ### BEFORE/AFTER SCREENSHOTS <!--- Skip this if not applicable --> Before: <img width="1512" height="736" alt="image" src="https://github.com/user-attachments/assets/86e6e6d0-9e27-4268-9d15-80103bea9e85"; /> <img width="1508" height="755" alt="image" src="https://github.com/user-attachments/assets/de7157be-341d-41c9-b9c7-d80346bd665c"; /> After: <img width="1512" height="755" alt="image" src="https://github.com/user-attachments/assets/121e8193-d981-4b42-a25a-30cc3cc5e592"; /> <img width="1506" height="759" alt="image" src="https://github.com/user-attachments/assets/faeb4316-07c7-4018-8423-e29cfbeaecf8"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Go to SQL Lab 2. Write some SQL (e.g., SELECT * FROM table) 3. Select text on that line To test with a custom color, add to your `superset_config.py`: ```py THEME_DEFAULT = { "token": { "colorEditorSelection": "#fff5cf", } } ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
