aminghadersohi opened a new pull request, #36935: URL: https://github.com/apache/superset/pull/36935
### SUMMARY Change the default behavior of the MCP `generate_chart` tool to create preview-only charts by default (`save_chart=False`), requiring explicit `save_chart=True` to permanently save charts in Superset. This enables a safer, more iterative workflow where LLM agents can preview charts before deciding to save them, reducing clutter from temporary or experimental visualizations. **Changes:** - Changed `save_chart` default from `True` to `False` in `GenerateChartRequest` schema - Updated docstring in `generate_chart.py` to reflect the new default behavior - Updated corresponding unit test to verify the new default ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A - This is a behavioral default change with no UI changes. ### TESTING INSTRUCTIONS 1. Call the MCP `generate_chart` tool without specifying `save_chart` 2. Verify that the chart is NOT saved to the database (preview-only mode) 3. Call with `save_chart=True` and verify the chart IS saved 4. Run MCP unit tests: `pytest tests/unit_tests/mcp_service/ -v` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
