shashbha14 opened a new pull request, #36951:
URL: https://github.com/apache/superset/pull/36951
SUMMARY
This PR addresses user confusion regarding customizing the loading icon and
resolves a bug where `LOGO_TARGET_PATH` was being ignored by the default theme
system in Superset 6.0.0.
Specifically, it:
1. **Documents Custom Loading Icon**: Explicitly documents
`brandSpinnerUrl` in `THEME_DEFAULT` within
[config.py](cci:7://file:///c:/Users/ishwet/superset/superset/config.py:0:0-0:0).
This clarifies that users can set a custom GIF/image loader via config without
needing to replace source files or rebuild assets.
2. **Fixes Logo Link**: Updates `THEME_DEFAULT` to correctly use
`LOGO_TARGET_PATH` for `brandLogoHref`. Previously, `LOGO_TARGET_PATH` was
ignored by the default theme, forcing users to override the entire theme object
just to change the logo link.
3. **Clarifies Configuration**: Added comments to `APP_ICON`,
`LOGO_TOOLTIP`, `LOGO_RIGHT_TEXT`, and `APP_ICON_WIDTH` (deprecation note) to
clarify their interaction with `THEME_DEFAULT` or their deprecated status.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A (Configuration and Documentation changes only)
TESTING INSTRUCTIONS
To verify these changes locally:
1. **Verify Logo Link Fix**:
* In `superset_config.py`, set `LOGO_TARGET_PATH =
"https://custom.url"`.
* Restart Superset and click the top-left logo.
* **Result**: It should navigate to `https://custom.url` (previously
it would stay on `/` unless the theme was overridden).
2. **Verify Custom Spinner**:
* In `superset_config.py`, set:
```python
THEME_DEFAULT = {
"token": {
"brandSpinnerUrl":
"/static/assets/images/my-custom-spinner.gif"
}
}
```
* Restart Superset.
* **Result**: The custom GIF should appear during loading.
ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #36940
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
