bito-code-review[bot] commented on code in PR #36952: URL: https://github.com/apache/superset/pull/36952#discussion_r2668596612
########## superset-frontend/packages/superset-core/src/api/sqlLab.ts: ########## @@ -280,19 +267,6 @@ export declare const onDidChangeEditorContent: Event<string>; */ export declare const onDidChangeEditorDatabase: Event<number>; Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Documentation Update</b></div> <div id="fix"> This change removes several event declarations from the SQL Lab API, which appears safe since no usage was found in the codebase. However, per project guidelines in AGENTS.md, user-facing API changes require documentation updates. The removed events are still listed in docs/developer_portal/extensions/development.md, so that file needs to be updated to reflect the API removal. Additionally, since this is a breaking change for potential extensions, it should be documented in UPDATING.md. </div> </div> <details> <summary><b>Citations</b></summary> <ul> <li> Rule Violated: <a href="https://github.com/apache/superset/blob/b830268/AGENTS.md#L79";>AGENTS.md:79</a> </li> <li> Rule Violated: <a href="https://github.com/apache/superset/blob/b830268/AGENTS.md#L80";>AGENTS.md:80</a> </li> </ul> </details> <small><i>Code Review Run #9878bf</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
