villebro commented on code in PR #36458: URL: https://github.com/apache/superset/pull/36458#discussion_r2669372435
########## superset/mcp_service/common/schema_discovery.py: ########## @@ -0,0 +1,422 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Schema discovery models for MCP tools. + +These schemas provide comprehensive metadata about available columns, +filters, and sorting options for each model type (chart, dataset, dashboard). +Column metadata is extracted dynamically from SQLAlchemy models. +""" + +from typing import Any, Dict, List, Literal, Type Review Comment: Nit, we should use `dict`, `list`, `"my_literal"` instead of these: ```suggestion from typing import Any, Type ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
