codeant-ai-for-open-source[bot] commented on PR #36955: URL: https://github.com/apache/superset/pull/36955#issuecomment-3720185658
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36955/files#diff-dd570ff35101701431c08f55fbcb607a8c70869e9eeaca9b184d1c04976397d8R207-R216'><strong>Possible Bug</strong></a><br>The code assumes `getRelatedChartsForChartCustomization` always returns an array of valid chart IDs and directly spreads its result into `affectedChartIds`. If the helper returns `null`, `undefined`, a non-array, or values that are not numeric IDs, this will cause incorrect entries or runtime errors. Add defensive checks and normalize values to numbers before using them to build the affected list.<br> - [ ] <a href='https://github.com/apache/superset/pull/36955/files#diff-0d3f1ec9aeea3a44207273ccf038e3d714778532407b311a168a26786caafa49R369-R377'><strong>Possible Bug</strong></a><br>The code calls `getRelatedChartsForChartCustomization(...)` and pushes its result into `affectedChartIds` without validating the return value or element types. If the utility returns undefined, non-array, or non-numeric identifiers, `dispatch(triggerQuery(true, chartId))` may be called with invalid arguments. Also ensure this behavior is correct for customizations that are `removed` (should they still trigger queries?).<br> - [ ] <a href='https://github.com/apache/superset/pull/36955/files#diff-dd570ff35101701431c08f55fbcb607a8c70869e9eeaca9b184d1c04976397d8R218-R223'><strong>Potential Dispatch Storm</strong></a><br>Even after narrowing down to related charts, the code dispatches a `triggerQuery` for every affected chart in a tight loop. For dashboards with many affected charts this can still cause many simultaneous requests. Consider filtering to existing slices, batching, or otherwise limiting concurrency.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
